Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PactValuesList type #200

Merged
merged 5 commits into from
Jan 2, 2023
Merged

Remove PactValuesList type #200

merged 5 commits into from
Jan 2, 2023

Conversation

EdwinGuayacan
Copy link
Contributor

Fixes #175

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@EdwinGuayacan EdwinGuayacan marked this pull request as ready for review December 29, 2022 16:54
L-Zuluaga
L-Zuluaga requested changes Dec 29, 2022
View reviewed changes
lib/chainweb/pact/command_payload.ex Outdated Show resolved Hide resolved
lib/chainweb/pact/command_payload.ex Outdated Show resolved Hide resolved
test/chainweb/pact/command_payload_test.exs Outdated Show resolved Hide resolved
test/chainweb/pact/command_payload_test.exs Outdated Show resolved Hide resolved
miguelnietoa
miguelnietoa requested changes Dec 29, 2022
View reviewed changes
lib/types/cap.ex Outdated Show resolved Hide resolved
@EdwinGuayacan EdwinGuayacan marked this pull request as draft December 30, 2022 19:59
miguelnietoa
miguelnietoa requested changes Dec 30, 2022
View reviewed changes
test/types/pact_value_test.exs Outdated Show resolved Hide resolved
lib/types/cap.ex Outdated Show resolved Hide resolved
lib/types/pact_value.ex Outdated Show resolved Hide resolved
@EdwinGuayacan EdwinGuayacan marked this pull request as ready for review December 30, 2022 22:37
L-Zuluaga
L-Zuluaga approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@L-Zuluaga L-Zuluaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EdwinGuayacan EdwinGuayacan merged commit 499e542 into kommitters:v0.12 Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelnietoa miguelnietoa miguelnietoa approved these changes

@L-Zuluaga L-Zuluaga L-Zuluaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdwinGuayacan @L-Zuluaga @miguelnietoa