Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Block Hash endpoint implementation (retrieve branches) #241

Merged
merged 6 commits into from
Jan 16, 2023
Merged

Add Block Hash endpoint implementation (retrieve branches) #241

merged 6 commits into from
Jan 16, 2023

Conversation

EdwinGuayacan
Copy link
Contributor

Fixes #221

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

EdwinGuayacan and others added 2 commits January 12, 2023 15:54
@EdwinGuayacan @Odraxs
Add Block Hash endpoint (retrieve branches)
8d4dbfb 
Co-authored-by: David Roldán <Odraxs@users.noreply.github.com>
@EdwinGuayacan
add improvement
820f8ef
@EdwinGuayacan EdwinGuayacan marked this pull request as ready for review January 12, 2023 22:05
miguelnietoa
miguelnietoa requested changes Jan 12, 2023
View reviewed changes
lib/chainweb/p2p/block_hash.ex Outdated Show resolved Hide resolved
lib/chainweb/p2p/block_hash_request_body.ex Outdated Show resolved Hide resolved
test/chainweb/p2p/block_hash_test.exs Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
einerzg
einerzg suggested changes Jan 16, 2023
View reviewed changes
Copy link

@einerzg einerzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EdwinGuayacan two comments!!!

README.md Outdated Show resolved Hide resolved
test/chainweb/p2p/block_hash_test.exs Show resolved Hide resolved
test/chainweb/p2p/block_hash_test.exs Show resolved Hide resolved
miguelnietoa
miguelnietoa requested changes Jan 16, 2023
View reviewed changes
Copy link
Member

@miguelnietoa miguelnietoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guys, giving a second review I realize that these tests are out of the describe "retrieve/1"

  • error with an invalid next
  • error with an invalid chain_id
  • error with a non existing location

@EdwinGuayacan EdwinGuayacan force-pushed the 221-block-hash-get-branches-endpoint branch from 6856e41 to 1e019ad Compare January 16, 2023 19:43
@EdwinGuayacan EdwinGuayacan merged commit 6685dd3 into kommitters:v0.13 Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einerzg einerzg einerzg approved these changes

@miguelnietoa miguelnietoa miguelnietoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdwinGuayacan @einerzg @miguelnietoa