-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid data embedded in the QR code #7
Comments
Hello Steve, any update on this issue? |
Looks like it's not the data but the error correction at the root of this. I am thinking currently that the ECC bytes are overriding the data and flipping a bit in the value. Note that |
This doesn't look trivial to get to the root of, but I have a quiet period coming up that may help me focus :) |
Steve, after verifying changes for #8 I found that |
Ok, let me see if I can get more strings. Going to be all URL-like strings. I get them 1 in 10 (on average). |
My current hypothesis is that the ec code is causing a bit flip, so will be interesting to see if other examples could be explained by a single bit flip. I do not yet understand root cause. |
Sent you some more string over email. |
That's useful test data - thank you, Vlad. I should be able to isolate the issue and resolve it with this test data. |
Doing a few "syndrome" checks on the ECC shows that there's an error correction code generation problem... close to a solution |
Fault in gf256 multiply function. Atom removed a bunch of trailing spaces, so these are in here too.
Vlad, this latest update passes my testing - can you confirm with yours? |
Steve, I tried it with |
Hello,
I'm encoding the following string into the QR:
http://localhost:4000/v1/sessions/9a454d3bb5d14369842f21a8f9683a87
which results in this image:The problem is that the actual data embedded in the QR is:
http://localhost:4000/v1/sessions/9a454d3bb5d14369842f21a8f9683a8'
. Notice the7
at the end turned into'
. I also saw similar errors which had 1 character wrong but not at the end of the string.Here's my
erl -v
One thing to note is that when using
Q
orL
error correction modes it is working fine, at least for the given input string.The text was updated successfully, but these errors were encountered: