Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup i18n dynamic path for locale file paths #110

Merged

Conversation

nicolas-brousse
Copy link
Member

Use a more precise path fot i18n load_path to avoid loading other yaml
file on components.

On a project I created an image component to easily generate an html picture tag. And so I also create a formats.yml to store my images formats I want to use.
And so with the current path used for i18n.load_path, my formats.yml file is loaded with locale files.

I do this update on my app and it seems good enough.

Use a more precise path fot i18n load_path to avoid loading other yaml
file on components.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 502

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 482: 0.0%
Covered Lines: 118
Relevant Lines: 118

💛 - Coveralls

@florentferry florentferry merged commit 8a761ad into komposable:master Aug 3, 2018
Spone pushed a commit that referenced this pull request Feb 26, 2019
Use a more precise path for i18n load_path to avoid loading other yaml
file on components.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants