New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Komponent::ComponentRenderer #70

Merged
merged 1 commit into from Mar 29, 2018

Conversation

2 participants
@florentferry
Member

florentferry commented Mar 4, 2018

No description provided.

@florentferry florentferry requested a review from Spone Mar 4, 2018

# frozen_string_literal: true
module Komponent
class Renderer

This comment has been minimized.

@florentferry

florentferry Mar 4, 2018

Member

ComponentRenderer instead ?

This comment has been minimized.

@Spone

Spone Mar 4, 2018

Collaborator

Sounds good to me

@@ -13,6 +13,7 @@ namespace :test do
t.libs << "lib"
t.test_files = FileList["test/**/*_test.rb"]
t.verbose = true
t.warning = false

This comment has been minimized.

@florentferry

florentferry Mar 4, 2018

Member

Remove that.

end
class ComponentRendererTest < ActionController::TestCase
def test_

This comment has been minimized.

@florentferry

florentferry Mar 4, 2018

Member

Naming it.

@florentferry florentferry requested a review from sigmike Mar 4, 2018

@florentferry florentferry added this to the 1.1.4 milestone Mar 4, 2018

@florentferry florentferry merged commit 1b1b448 into master Mar 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@florentferry florentferry deleted the move-logic-from-helper-to-class branch Mar 29, 2018

florentferry added a commit that referenced this pull request Mar 30, 2018

florentferry added a commit that referenced this pull request Mar 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment