Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Komponent::ComponentRenderer #70

Merged
merged 1 commit into from
Mar 29, 2018

Conversation

florentferry
Copy link
Member

No description provided.

@florentferry florentferry requested a review from Spone March 4, 2018 19:47
# frozen_string_literal: true

module Komponent
class Renderer
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ComponentRenderer instead ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

@@ -13,6 +13,7 @@ namespace :test do
t.libs << "lib"
t.test_files = FileList["test/**/*_test.rb"]
t.verbose = true
t.warning = false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove that.

end

class ComponentRendererTest < ActionController::TestCase
def test_
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming it.

@florentferry florentferry added this to the 1.1.4 milestone Mar 4, 2018
@florentferry florentferry force-pushed the move-logic-from-helper-to-class branch 4 times, most recently from aa8b823 to 2564739 Compare March 6, 2018 22:07
@florentferry florentferry force-pushed the move-logic-from-helper-to-class branch from 2564739 to f6ce86a Compare March 29, 2018 19:40
@florentferry florentferry merged commit 1b1b448 into master Mar 29, 2018
@florentferry florentferry deleted the move-logic-from-helper-to-class branch March 29, 2018 20:15
florentferry added a commit that referenced this pull request Mar 30, 2018
florentferry added a commit that referenced this pull request Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants