Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use component_name instead of module_name in templates #99

Merged
merged 2 commits into from
Jun 10, 2018
Merged

Use component_name instead of module_name in templates #99

merged 2 commits into from
Jun 10, 2018

Conversation

Spone
Copy link
Collaborator

@Spone Spone commented Jun 9, 2018 •
edited
Loading

So when we create a button component, by default it contains button instead of button_component (makes more sense imho)

@Spone Spone self-assigned this Jun 9, 2018
@Spone Spone requested a review from florentferry June 9, 2018 17:08
@Spone Spone force-pushed the fix-view-templates-content branch from 30ce52a to 906e6a8 Compare June 9, 2018 17:12
@coveralls
Copy link

coveralls commented Jun 9, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 408

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 379: 0.0%
Covered Lines: 120
Relevant Lines: 120
💛 - Coveralls

@florentferry florentferry merged commit 6887186 into master Jun 10, 2018
@florentferry florentferry deleted the fix-view-templates-content branch June 10, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florentferry florentferry Awaiting requested review from florentferry

Assignees

@Spone Spone

Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Spone @coveralls @florentferry