-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use multiplatform big numbers #96
base: master
Are you sure you want to change the base?
Use multiplatform big numbers #96
Conversation
…orm implementation (except for java crypto implementations)
The bugs in 'kotlin-multiplatform-bignum' have been resolved. |
@ligi Conversion is almost complete, would love to get your feedback! Some Notes about migration:
|
In general it looks like really good work! I would just wait with merging until:
|
I agree. Regarding the leading zeros I think I fixed the bug and submitted a PR. We will wait for the next stable release of 'kotlin-multiplatform-bignum'. Can you please look at this PR? |
Leading zeroes fix is merged and I'll try to get a stable release today or tomorrow. |
0.2.8 is released https://repo1.maven.org/maven2/com/ionspin/kotlin/bignum/ |
…/KEthereum into use_multiplatform_big_numbers
Part of an overall effort to make KEthereum multiplatform (focusing on JVM/JS).
Trying to replace java.math.BigInteger and java.math.BigDecimal with multiplatform alternatives from 'kotlin-multiplatform-bignum' as already done successfully as part of multiplatform support for KHash.
Started by adding the jvm variant as a common dependency to all sub-modules followed by converting both main and test sources. Fixed some issues but it is still WIP and pending some issues reported that result in test failures.
The only usages of java.math.BigInteger are in crypto jvm-specific implementation such as SpongyCastle or BouncyCastle
that internally use java's BigInteger to interact with jvm libraries. The crypto API uses kotlin BigInteger and underlying implementation can convert from/to java's.