Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0.0-RC3 - Build fix #6

Merged
merged 12 commits into from
May 14, 2019
Merged

Version 1.0.0-RC3 - Build fix #6

merged 12 commits into from
May 14, 2019

Conversation

RiccardoM
Copy link
Contributor

Removed the @see reference inside the documentation in order to (hopefully) remove build errors while executing :core:dokkaJavadoc and :extensions:dokkaJavadoc that failed in previous versions

RiccardoM and others added 10 commits April 12, 2019 09:25
- Added the real support for js and native platforms
- Removed the Hex object to avoid unnecessary overhead
- Renamed the `khex` module into `core`
- Renamed the `khex-extensions` module into `extensions`
- Changed the project group to `org.komputing.khex`
- Added Gradle Wrapper
- Updated the project group id to reflect the one that Jitpack choses
- Removed documentation @see reference
…-Rc3

# Conflicts:
#	extensions/common/src/org/komputing/khex/extensions/ByteArrayExtensions.kt
#	extensions/common/src/org/komputing/khex/extensions/ByteListExtensions.kt
#	gradle.properties
@RiccardoM RiccardoM mentioned this pull request May 14, 2019
@ligi
Copy link
Member

ligi commented May 14, 2019

thanks - trying it out currently

@ligi
Copy link
Member

ligi commented May 14, 2019

unfortunately it does not seem to solve the problem:

https://jitpack.io/com/github/komputing/khex/jitpack_test/build.log

- Updated the Gradle wrapper to version 5.4.1
- Downgraded dokka to version 0.9.17 due to current bug: Kotlin/dokka#462
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 confirmed this now solves the problem 🎉

@ligi ligi merged commit cdc6b5b into komputing:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants