-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.0.0-RC3 - Build fix #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added the real support for js and native platforms - Removed the Hex object to avoid unnecessary overhead - Renamed the `khex` module into `core` - Renamed the `khex-extensions` module into `extensions` - Changed the project group to `org.komputing.khex`
- Removed documentation @see reference
…-Rc3 # Conflicts: # extensions/common/src/org/komputing/khex/extensions/ByteArrayExtensions.kt # extensions/common/src/org/komputing/khex/extensions/ByteListExtensions.kt # gradle.properties
Closed
thanks - trying it out currently |
unfortunately it does not seem to solve the problem: https://jitpack.io/com/github/komputing/khex/jitpack_test/build.log |
- Updated the Gradle wrapper to version 5.4.1 - Downgraded dokka to version 0.9.17 due to current bug: Kotlin/dokka#462
ligi
approved these changes
May 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 confirmed this now solves the problem 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the @see reference inside the documentation in order to (hopefully) remove build errors while executing :core:dokkaJavadoc and :extensions:dokkaJavadoc that failed in previous versions