Feat/r2dbc sourcing #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 12, 2024 23:28
refactor(GuardExecutor.kt): reformat verifyInitTransition and verifyTransition functions for better readability
refactor(S2AutomateExecutor.kt): update createInit and doTransition functions to use more descriptive parameter names and return types for clarity and consistency
The update to the VERSION_C2 variable in the .env_dev file ensures that the correct version is used for the C2 component. The refactoring of the GuardExecutor.kt file improves the readability of the code by reformatting the verifyInitTransition and verifyTransition functions. Similarly, the refactoring of the S2AutomateExecutor.kt file enhances clarity by updating parameter names and return types in the createInit and doTransition functions.
feat(S2AutomateExecutorImpl.kt): add support for handling AutomateSessionError and ERROR_UNKNOWN exceptions in S2AutomateExecutorImpl
The changes introduce support for handling AutomateSessionError and ERROR_UNKNOWN exceptions in the S2AutomateExecutorImpl class. This allows for better error handling and management within the automation execution process. The code now includes specific error handling logic for these exceptions, improving the robustness and reliability of the automation execution flow.
refactor(S2AutomateExecutorImpl.kt): simplify return statement using 'to' operator instead of Pair constructor
refactor(S2AutomateExecutorImpl.kt): update return type of createInit function to Flow<EVENT_OUT> for better clarity and consistency
refactor(S2AutomateExecutorImpl.kt): simplify mapping of persistContext to EVENT_OUT type
refactor(S2AutomateExecutorImpl.kt): remove unnecessary return statement in prepareCreationContext function
refactor(S2AutomateExecutorImpl.kt): remove redundant code and improve readability in prepareCreationContext function
refactor(S2AutomateExecutorImpl.kt): remove commented-out code for doTransitionFlow function
refactor(S2AutomateExecutorImpl.kt): update return type of doTransitionFlow function to Flow<EVENT_OUT> for better clarity and consistency
refactor(S2AutomateExecutorImpl.kt): refactor doTransitionFlow function to collect transition contexts and execute commands
refactor(S2AutomateExecutorImpl.kt): simplify error handling in handleException function
The changes were made to improve code readability, simplify return statements, update return types for better clarity, and refactor error handling for better maintainability and consistency.
fix(core): remove generic type parameter from AutomateSessionError class and related methods
refactor(listener): update AutomateListener and AutomateListenerAdapter to remove generic type parameter from automateSessionError method
refactor(publisher): update AutomateEventPublisher to remove generic type parameter from automateSessionError method
refactor(error): update ERROR_UNKNOWN function to include a nullable exception parameter
refactor(guard): update GuardExecutorImpl to improve readability by splitting long function parameters into multiple lines
refactor(persist): update AutomatePersister to change return type from Flow<ENTITY> to Flow<EVENT> for persistInitFlow and persistFlow methods
refactor(dsl): update s2error function to include default values for payload and cause parameters
refactor(ssm): update EventPersisterSsm to optimize persistFlow method by using flow{} builder and emitAll function
The changes were made to remove unnecessary generic type parameters from classes and methods, improve code readability by splitting long function parameters, update function signatures for consistency, and optimize the persistFlow method for better performance.
fix(s2-spring): fix return type of persistSnap method to return Pair<ENTITY, EVENT> instead of just ENTITY
refactor(s2-spring): refactor persist method to handle Flow of events and return Flow of Pair<ENTITY, EVENT>
refactor(s2-spring): refactor persistInitFlow and persistFlow methods to correctly handle saving entities and returning events
The changes were made to improve the code readability and maintainability by ensuring that the methods return the correct types and handle Flow of events appropriately. The refactoring also aims to enhance the overall functionality of persisting events and entities in the application.
fix(persister): update persistFlow method to correctly save entities and map events
fix(persister): update persistInitFlow method to return events instead of entities
fix(SsmAutomatePersister): refactor persist method to return Pair of entity and event
feat(persister): add support for saving multiple entities in persistFlow method
feat(persister): introduce zip operator to map saved entities back to events in persistFlow method
The changes were made to improve the logic of persisting data in the Spring Data Automate Persister and Reactive Persister classes. The persistFlow and persistInitFlow methods were updated to return events instead of entities. The persist method in SsmAutomatePersister was refactored to return a Pair of entity and event. Additionally, support for saving multiple entities and mapping saved entities back to events was added to the persistFlow method.
feat(OrderBookDeciderImplTest.kt): add support for kotlinx.coroutines.test.runTest to improve test reliability
refactor(OrderBookDeciderImplTest.kt): refactor test methods to use runTest instead of runBlocking for better handling of coroutines
The changes were made to enhance the reliability of the test cases by using runTest from kotlinx.coroutines.test instead of runBlocking. This change ensures better handling of coroutines in the test environment, improving the overall quality and stability of the tests.
…necessary comments, simplify doTransitionFlow method implementation The commit removes commented-out code and unnecessary comments in the `S2AutomateExecutorImpl.kt` file. It simplifies the `doTransitionFlow` method implementation by removing redundant comments and streamlining the code for better readability and maintainability.
…ersistFlow methods to improve clarity and consistency feat(persist methods): refactor persistInitFlow and persistFlow methods to collect and save entities in batches for improved performance and efficiency The parameter names in the persistInitFlow and persistFlow methods have been updated to transitionContexts to improve clarity and consistency with other methods. The methods have been refactored to collect entities in batches from the transition contexts and save them in bulk to improve performance and efficiency. This change enhances the overall performance of the data persistence operations.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.