Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a config option #27

Closed
komuw opened this issue Sep 16, 2021 · 2 comments · Fixed by #28 or #58
Closed

add a config option #27

komuw opened this issue Sep 16, 2021 · 2 comments · Fixed by #28 or #58

Comments

@komuw
Copy link
Owner

komuw commented Sep 16, 2021

kama.Dirp(x, ...config)

where config is optional.

struct config{
compact bool,
redact bool,
hideZeroValues bool,
}

maybe #24 should also be an option on the config struct?

@komuw
Copy link
Owner Author

komuw commented Sep 16, 2021

adding configs is against a 'no config' principle of kama. this can be a slippery slope.

@komuw
Copy link
Owner Author

komuw commented Sep 30, 2021

alternatively, do not compact at all.
In my usage, compaction is more of a nuisance.

@komuw komuw closed this as completed in #28 Dec 6, 2021
komuw added a commit that referenced this issue Dec 6, 2021
What:
- do not compact by default

Why:
- fixes: #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant