Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix onsen name #84

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Feature/fix onsen name #84

merged 5 commits into from
Apr 2, 2024

Conversation

konabe
Copy link
Owner

@konabe konabe commented Apr 2, 2024

No description provided.

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onsen-tabi-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 11:16pm
onsen-tabi-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 11:16pm

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.14%. Comparing base (1fb6250) to head (d577f4d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   82.77%   83.14%   +0.37%     
==========================================
  Files          55       56       +1     
  Lines        3982     4011      +29     
  Branches      312      315       +3     
==========================================
+ Hits         3296     3335      +39     
+ Misses        682      673       -9     
+ Partials        4        3       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Apr 2, 2024

Bundle Report

Changes will increase total bundle size by 328 bytes ⬆️

Bundle name Size Change
main-esm 805.92kB 328 bytes ⬆️

Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
69.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@konabe konabe merged commit 0fded58 into main Apr 2, 2024
7 of 8 checks passed
@konabe konabe deleted the feature/fix-onsen-name branch April 2, 2024 23:21
@konabe konabe mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant