-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi platform build with kotlin 2.0.0 #106
Conversation
Let's wait for the final release for kotlin 2.0 and then update this PR. This adds native, wasm, and other multiplatform targets. |
I haven't looked much at 2.0 yet. Do you know the backwards compatibility guarantees? If we compile with 2.0, what is the minimum kotlin version for users of the library? Didn't spot it in the release notes. In current main it's compiled with 1.9 and minimum kotlin user version is 1.7. Might be that they address this in the full 2.0 release. |
They continue to support older versions. I've kept the 1.7 target. So I expect things should work. |
Fixes #68 |
configure wasm target correctly to get rid of the warning
This is now ready to be merged now that 2.0.0 is out. |
// note lang toolchain cannot be used here | ||
// because gradle no longer supports running on java 8 | ||
jvmTarget = jvm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to bumping the JVM target version, but it should be 11 (LTS) instead of 10, and preferably for a good reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, my bad, I was getting some weird error earlier. It seems 1.8 works after all. I meant to update to 11 but was getting an error. I'll push the fix.
Thanks! |
Looks like there's some more work to do to support the iOS targets
|
You need xcode and a mac for that. Worked fine on my machine. But I'm not actively doing any ios development. |
Yeah a macos github actions runner is necessary to build the ios targets in PRs and do the ios release, that's what I meant |
addresses #102