Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi platform build with kotlin 2.0.0 #106

Merged
merged 12 commits into from
Jun 2, 2024
Merged

Conversation

jillesvangurp
Copy link
Collaborator

addresses #102

@jillesvangurp
Copy link
Collaborator Author

Let's wait for the final release for kotlin 2.0 and then update this PR.

This adds native, wasm, and other multiplatform targets.

@dhoepelman
Copy link
Collaborator

dhoepelman commented May 10, 2024

I haven't looked much at 2.0 yet. Do you know the backwards compatibility guarantees? If we compile with 2.0, what is the minimum kotlin version for users of the library? Didn't spot it in the release notes. In current main it's compiled with 1.9 and minimum kotlin user version is 1.7.

Might be that they address this in the full 2.0 release.

@jillesvangurp
Copy link
Collaborator Author

They continue to support older versions. I've kept the 1.7 target. So I expect things should work.

@dhoepelman
Copy link
Collaborator

Fixes #68

@jillesvangurp jillesvangurp changed the title multi platform build with kotlin 2.0 RC2 multi platform build with kotlin 2.0.0 May 22, 2024
@jillesvangurp
Copy link
Collaborator Author

This is now ready to be merged now that 2.0.0 is out.

Comment on lines +55 to +57
// note lang toolchain cannot be used here
// because gradle no longer supports running on java 8
jvmTarget = jvm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not true?

I'm not opposed to bumping the JVM target version, but it should be 11 (LTS) instead of 10, and preferably for a good reason.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, my bad, I was getting some weird error earlier. It seems 1.8 works after all. I meant to update to 11 but was getting an error. I'll push the fix.

@dhoepelman dhoepelman enabled auto-merge (squash) June 2, 2024 11:19
@dhoepelman
Copy link
Collaborator

Thanks!

@dhoepelman dhoepelman mentioned this pull request Jun 2, 2024
@dhoepelman dhoepelman merged commit 285db7e into main Jun 2, 2024
1 check passed
@dhoepelman dhoepelman deleted the kotlin-2-and-multiplatform branch June 2, 2024 11:21
@dhoepelman
Copy link
Collaborator

Looks like there's some more work to do to support the iOS targets

w: The following Kotlin/Native targets cannot be built on this machine and are disabled:
iosArm64, iosX64, macosArm64, macosX64, tvosArm64, tvosX64, watchosArm32, watchosArm64, watchosX64

@jillesvangurp
Copy link
Collaborator Author

You need xcode and a mac for that. Worked fine on my machine. But I'm not actively doing any ios development.

@dhoepelman
Copy link
Collaborator

Yeah a macos github actions runner is necessary to build the ios targets in PRs and do the ios release, that's what I meant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants