Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi platform build with kotlin 2.0.0 #106

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jillesvangurp
Copy link
Collaborator

addresses #102

@jillesvangurp
Copy link
Collaborator Author

Let's wait for the final release for kotlin 2.0 and then update this PR.

This adds native, wasm, and other multiplatform targets.

@dhoepelman
Copy link
Collaborator

dhoepelman commented May 10, 2024

I haven't looked much at 2.0 yet. Do you know the backwards compatibility guarantees? If we compile with 2.0, what is the minimum kotlin version for users of the library? Didn't spot it in the release notes. In current main it's compiled with 1.9 and minimum kotlin user version is 1.7.

Might be that they address this in the full 2.0 release.

@jillesvangurp
Copy link
Collaborator Author

They continue to support older versions. I've kept the 1.7 target. So I expect things should work.

@dhoepelman
Copy link
Collaborator

Fixes #68

@jillesvangurp jillesvangurp changed the title multi platform build with kotlin 2.0 RC2 multi platform build with kotlin 2.0.0 May 22, 2024
@jillesvangurp
Copy link
Collaborator Author

This is now ready to be merged now that 2.0.0 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants