Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor LocationService::processState() #5

Closed
konkers opened this issue Dec 19, 2018 · 1 comment
Closed

Refactor LocationService::processState() #5

konkers opened this issue Dec 19, 2018 · 1 comment
Labels
code health

Comments

@konkers
Copy link
Owner

konkers commented Dec 19, 2018

It has grown unwieldy:

cids-workshop/src/app/location.service.ts

Line 80 in 5f661da

private processState(state: State, locationsData: Locations): LocationStates {

@konkers konkers mentioned this issue Dec 19, 2018
Merged
@konkers konkers reopened this Dec 19, 2018
@konkers
Copy link
Owner Author

konkers commented Dec 19, 2018

Bad attribution

konkers added a commit that referenced this issue Dec 26, 2018
@konkers
Refactor LocationService::processState().
f8402b7 
Fixes #5
@konkers konkers mentioned this issue Dec 26, 2018
Merged
konkers added a commit that referenced this issue Dec 26, 2018
@konkers
Refactor LocationService::processState().
96dfa57 
Fixes #5
konkers added a commit that referenced this issue Dec 27, 2018
@konkers
Add Kq and Km support.
3b0d1d4 
This required some pretty invasive work.

Adds Boss support ofr #5.
@konkers konkers mentioned this issue Dec 27, 2018
Merged
konkers added a commit that referenced this issue Dec 27, 2018
@konkers
Add Kq and Km support.
fc9ac50 
This required some pretty invasive work.

Adds Boss support ofr #5.
konkers added a commit that referenced this issue Mar 8, 2019
@konkers
Refactor LocationService::processState().
de4122c 
Fixes #5
konkers added a commit that referenced this issue Mar 8, 2019
@konkers
Add Kq and Km support.
727b955 
This required some pretty invasive work.

Adds Boss support ofr #5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code health
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@konkers