Skip to content
This repository has been archived by the owner on Dec 4, 2017. It is now read-only.

Don't reinvent git #1

Merged
merged 3 commits into from
Jul 7, 2013
Merged

Don't reinvent git #1

merged 3 commits into from
Jul 7, 2013

Conversation

benbalter
Copy link
Contributor

Use Git to track changes, rather than reinventing it.

This not only reduces the complexity of the code, but provides for better storage and analysis of changes over time by leveraging Git's built in version tracking and diffing capabilities.

Additionally, now other users that fork the project can take advantage of past crawls or perform analysis of past changes.

Other changes:

  • Fixes compatibility issue when Twillo was not configured by wrapping config in conditional block.
  • Rather than listing gems in the readme, lets just go ahead and user bundler.
  • Use open-uri rather then shelling out to wget

Use Git to track changes, rather than [reinventing it](https://twitter.com/konklone/status/353960261398433793).

This not only reduces the complexity of the code, but provides for better
storage and analysis of changes over time by leveraging Git's built in
version tracking and diffing capabilities.

Additionally, now other users that fork the project can take advantage
of past crawls or perform analysis of past changes.
@konklone
Copy link
Owner

konklone commented Jul 7, 2013

This is exactly the approach I wanted to take, thank you for jumping on this with such alacrity. I'd actually rather not use Bundler for this, as for a tiny command-line script it adds more complexity than it removes, but I can take care of that.

Testing this out now, will look to merge promptly.

konklone added a commit that referenced this pull request Jul 7, 2013
@konklone konklone merged commit b261184 into konklone:master Jul 7, 2013
@benbalter benbalter deleted the git branch July 7, 2013 21:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants