Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multi runtime support #58

Merged
merged 17 commits into from
Feb 27, 2023

Conversation

JYisus
Copy link
Contributor

@JYisus JYisus commented Feb 16, 2023

Description

Add multiruntime support to existent commands, refactor whole application, clean tests, and add runtime commands.

Motivation and Context

Since the latest version of KAI Server (aka KRE) works with multiple runtimes, KLI had to be updated to support this functionality. Also, the KLI code was a bit messy, so a refactor would help to the maintenance and the readability.

Types of changes

  • New feature: Runtime commands
  • New feature: Update KRT config version command
  • New feature: More options in KRT build command
  • Breaking change: Multiruntime supports in kre commands
  • Breaking change: Reorganization of the commands structure
  • Refactor whole application

Checklist:

  • I have created tests for my code changes, and the tests are passing.
  • I have updated the documentation accordingly.

dfinteligenz
dfinteligenz previously approved these changes Feb 23, 2023
Copy link
Contributor

@dfinteligenz dfinteligenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @JYisus!

alexrodfe
alexrodfe previously approved these changes Feb 27, 2023
Copy link
Contributor

@alexrodfe alexrodfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelent!! 🦾

@JYisus JYisus dismissed stale reviews from alexrodfe and dfinteligenz via e8ef5b2 February 27, 2023 16:39
@JYisus JYisus merged commit 4b6162a into main Feb 27, 2023
@JYisus JYisus deleted the KNT1-20-Add-multi-runtime-support-on-the-KLI branch February 27, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants