Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable kubelet read-only port #76

Merged
merged 3 commits into from
Mar 14, 2018
Merged

Disable kubelet read-only port #76

merged 3 commits into from
Mar 14, 2018

Conversation

jakolehm
Copy link
Contributor

No description provided.

@jakolehm jakolehm added the bug Something isn't working label Mar 14, 2018
@jakolehm
Copy link
Contributor Author

jakolehm commented Mar 14, 2018 •
edited
Loading

Todo: how to configure heapster and metrics-server? /cc @SpComb @jnummelin

@SpComb
Copy link
Contributor

SpComb commented Mar 14, 2018 •
edited
Loading

https://kubernetes.io/docs/admin/kubelet-authentication-authorization/

kubeadm configures the kubelet with --client-ca-file, so access to the https://*:10250 requires a valid client cert signed by the kube CA... --authorization-mode=Webhook will also require a service account bearer token the client cert subject to be authorized to access the stats subresource?

@jakolehm
Copy link
Contributor Author

@SpComb PTAL

@jakolehm jakolehm merged commit ddba531 into master Mar 14, 2018
@jakolehm jakolehm deleted the fix/disable-kubelet-read-only-port branch March 14, 2018 16:57
@jakolehm jakolehm added this to the 0.3 milestone Mar 15, 2018
@SpComb
Copy link
Contributor

SpComb commented Mar 15, 2018

@SpComb PTAL

I don't understand how the metrics-server => kubelet API auth works, so I can't review this without testing that part... started on that yesterday but not enough time to finish.

@SpComb SpComb mentioned this pull request Mar 20, 2018
Closed
jakolehm added a commit that referenced this pull request Mar 20, 2018
@jakolehm
Revert "Disable kubelet read-only port (#76)"
486ac0d 
This reverts commit ddba531.
jakolehm added a commit that referenced this pull request Mar 20, 2018
@jakolehm
Revert "Disable kubelet read-only port (#76)" (#120)
15c9f21 
This reverts commit ddba531.
@SpComb SpComb mentioned this pull request Apr 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jakolehm @SpComb