Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MAPI JSD SDK Peer dependency #24

Merged
merged 16 commits into from
Aug 5, 2021
Merged

Make MAPI JSD SDK Peer dependency #24

merged 16 commits into from
Aug 5, 2021

Conversation

Simply007
Copy link
Contributor

@Simply007 Simply007 commented Jun 21, 2021 •
edited by winklertomas
Loading

Motivation

Fixes #21

TODO:

  • Resolve all // TODO ... comments
  • Release final version

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@Simply007
Copy link
Contributor Author

Released 0.1.0-next.1 under next tag on npm: https://www.npmjs.com/package/@kentico/kontent-cli/v/0.1.0-next.1

commit tag: https://github.com/Kentico/kontent-cli/releases/tag/0.1.0-next.1

@Simply007 Simply007 mentioned this pull request Jun 22, 2021
Closed
5 tasks
@Simply007 Simply007 mentioned this pull request Jun 22, 2021
Merged
Simply007
Simply007 commented Jul 13, 2021
View reviewed changes
src/cmds/backup.ts Show resolved Hide resolved
src/managementClientFactory.ts Outdated Show resolved Hide resolved
src/cmds/backup.ts Outdated Show resolved Hide resolved
@Simply007 Simply007 marked this pull request as ready for review July 29, 2021 10:22
@Simply007 Simply007 requested a review from a team July 29, 2021 10:22
winklertomas
winklertomas approved these changes Aug 5, 2021
View reviewed changes
src/cmds/backup.ts Show resolved Hide resolved
src/cmds/backup.ts Outdated Show resolved Hide resolved
src/managementClientFactory.ts Outdated Show resolved Hide resolved
winklertomas
winklertomas approved these changes Aug 5, 2021
View reviewed changes
src/cmds/backup.ts Outdated Show resolved Hide resolved
@winklertomas winklertomas merged commit 109d945 into master Aug 5, 2021
@winklertomas winklertomas deleted the feature/21 branch August 5, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winklertomas winklertomas winklertomas approved these changes

Assignees
No one assigned
Labels
do-not-marge
Projects
None yet
Milestone
vNext - Modularize Kontent CLI
Development

Successfully merging this pull request may close these issues.

Make Kontent MAPI SDK a peer dependency
2 participants
@Simply007 @winklertomas