Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade management SDK version in peer dependencies #30

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

vladbulyukhin
Copy link

Motivation

We are planning to add new features to the management SDK, and we need it to work with kontent-cli. However, those features won't be available in the first version of the management SDK. Is it OK to upgrade @kentico/kontent-management package version in peer dependencies?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

@vladbulyukhin vladbulyukhin requested a review from a team February 14, 2022 16:52
Copy link
Contributor

@winklertomas winklertomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've upped the version and fixed our migration boilerplate to work with the new version. I also updated the version of the kontent-backup-manager and tested it

@winklertomas winklertomas merged commit 505a553 into master Feb 18, 2022
@winklertomas winklertomas deleted the feature/KCL-8382-NLEs-in-content-types-MAPI-CLI branch February 18, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants