Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #119
I did not add the specific
DateTime
anddecimal
constructors. I have also kept the original method signatures for all of the filters for backward compatibility.The issue (#119) calls out that all filters should implement
DateTime
anddecimal
constructors, then utilize a new constructor inFilter
to acceptobject
s as values. The original issue (#27), has a proposed solution in such a way; however, doing so defeats the purpose of creating a generic filter in the first place. Since, if we were to go theobject
route, all values would get converted to astring
, removing the need for a generic and forGetQueryStringParameter
to handle types in aswitch
.Instead, I opted to go the route of the generic filter and implemented a switch statement to interpret
string
,DateTime
, and numeric types (int
,decimal
,float
, etc.). The downside here is that we lose the specific constructors forDateTime
anddecimal
values.Checklist
How to test
Create queries using the new filters and confirm that results are correctly filtered.