Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seo metadata content type snippets #94

Merged
merged 10 commits into from
Sep 3, 2018
Merged

seo metadata content type snippets #94

merged 10 commits into from
Sep 3, 2018

Conversation

liamgold
Copy link
Contributor

@liamgold liamgold commented Sep 1, 2018

This is related to #55

@liamgold
Copy link
Contributor Author

liamgold commented Sep 1, 2018

Fixed the case sensitivity issues with the rebuilt models!

Please review and let me know if the implementation is wrong, or recommend any changes 👍

@liamgold liamgold changed the title Feature/seo metadata seo metadata content type snippets Sep 1, 2018
@petrsvihlik petrsvihlik self-requested a review September 3, 2018 11:58
@petrsvihlik petrsvihlik merged commit 1797a32 into kontent-ai:master Sep 3, 2018
@petrsvihlik
Copy link
Contributor

it looks good to me -> merged ;) thanks @liamgold !

cbeard87 added a commit to cbeard87/cloud-sample-app-react that referenced this pull request Sep 4, 2018
@petrsvihlik
Copy link
Contributor

would you be interested in another JavaScript issue? we can suggest you some that we need help with. e.g. kontent-ai/sample-app-vue#1

@liamgold liamgold deleted the feature/seo-metadata branch September 4, 2018 17:32
@liamgold
Copy link
Contributor Author

liamgold commented Sep 4, 2018

Sure - I've not used Vue before so might be a nice to investigate. Especially since the proposed fix is based upon the React solution

@petrsvihlik
Copy link
Contributor

awesome! i can assign the issue to you if you accept the invite to the project ;)

@liamgold
Copy link
Contributor Author

liamgold commented Sep 4, 2018

Cool, I've accepted the invite.

@Simply007
Copy link
Contributor

Hey @liamgold,

we would like to thank you for contributing to Kentico's open-source project. As a sign of our appreciation, we would like to send you some Kentico Developer Community SWAG!

Please fill out your postal address if you are interested.

This comment was automatically generated. If you've submitted more than one pull request, it's OK to fill out the form just once.

Kentico Developer Community

If there’s anything we can do to help, please don’t hesitate to reach out to us at developerscommunity@kentico.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants