Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsconfig ilb to es2019 #1827

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

tbo47
Copy link

@tbo47 tbo47 commented Oct 4, 2024

to fix this errors:

src/shapes/Text.ts:565:27 - error TS2550: Property 'trimRight' does not exist on type 'string'. Do you need to change your target library? Try changing the 'lib' compiler option to 'es2019' or later.

565             match = match.trimRight();
                              ~~~~~~~~~

src/shapes/Text.ts:582:25 - error TS2550: Property 'trimLeft' does not exist on type 'string'. Do you need to change your target library? Try changing the 'lib' compiler option to 'es2019' or later.

582             line = line.trimLeft();
                            ~~~~~~~~

@lavrton
Copy link
Member

lavrton commented Oct 5, 2024

How do you see that error?

@tbo47
Copy link
Author

tbo47 commented Oct 5, 2024

➜  konva git:(master) tsc -v
Version 5.6.2
➜  konva git:(master) tsc

...

src/shapes/Text.ts:565:27 - error TS2550: Property 'trimRight' does not exist on type 'string'. Do you need to change your target library? Try changing the 'lib' compiler option to 'es2019' or later.

565             match = match.trimRight();
                              ~~~~~~~~~

src/shapes/Text.ts:582:25 - error TS2550: Property 'trimLeft' does not exist on type 'string'. Do you need to change your target library? Try changing the 'lib' compiler option to 'es2019' or later.

582             line = line.trimLeft();
                            ~~~~~~~~

@lavrton
Copy link
Member

lavrton commented Oct 7, 2024

Hmm... Not sure why I don't see anything...

@lavrton lavrton merged commit f153853 into konvajs:master Oct 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants