🐛 stop building the project when we don't need anything else #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shawn Hurley <shawn@hurley.page>
shawn-hurley
force-pushed
the
bugfix/dont-build-project
branch
from
a33ad8b
to
a942424
Compare
|
@jmle @pranavgaikwad It looks like this change is a nice compromise for #358. We won't create a target directory anymore (as seen in the e2e tests), BUT if one exists, then it will be searched AFAICT. WDYT? |
|
@shawn-hurley that sounds good to me.. We need to remove this https://github.com/konveyor/go-konveyor-tests/blob/c5e0436cd5662025e89a090d5cd88adfd30112d3/analysis/tc_tackle_testapp_public.go#L38-L43 |
|
Yep, I am working on that PR now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to wait for the build for the init step to be complete.
API tests PR: 102