🐛 removing testcase that finds the target, because we no longer create (

#102) (#118) * removing testcase that finds the target, because we no longer create it by default --------- Signed-off-by: Shawn Hurley <shawn@hurley.page> Co-authored-by: Shawn Hurley <shawn@hurley.page>
konveyor · Apr 30, 2024 · 3b05cff · 3b05cff
1 parent e9db50a
commit 3b05cff
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 24 deletions.
diff --git a/analysis/tc_tackle_testapp_public.go b/analysis/tc_tackle_testapp_public.go
@@ -26,7 +26,7 @@ var TackleTestappPublic = TC{
 	},
 	Identities: []api.Identity{},
 	Analysis: api.Analysis{
-		Effort: 9,
+		Effort: 8,
 		Issues: []api.Issue{
 			{
 				Category:    "mandatory",
@@ -35,12 +35,6 @@ var TackleTestappPublic = TC{
 				RuleSet:     "discovery-rules",
 				Rule:        "hardcoded-ip-address",
 				Incidents: []api.Incident{
-					{
-						File:     "/addon/source/tackle-testapp-public/target/classes/persistence.properties",
-						Line:     2,
-						Message:  "When migrating environments, hard-coded IP addresses may need to be modified or eliminated.",
-						CodeSnip: "jdbc.url=jdbc:oracle:thin:@10.19.2.93:15",
-					},
 					{
 						File:     "/addon/source/tackle-testapp-public/src/main/resources/persistence.properties",
 						Line:     2,

diff --git a/analysis/tc_tackle_testapp_public_deps.go b/analysis/tc_tackle_testapp_public_deps.go
@@ -24,7 +24,7 @@ var TackleTestappPublicWithDeps = TC{
 
 	},
 	Analysis: api.Analysis{
-		Effort: 3,
+		Effort: 2,
 		Issues: []api.Issue{
 			{
 				Category:    "mandatory",
@@ -33,12 +33,6 @@ var TackleTestappPublicWithDeps = TC{
 				RuleSet:     "discovery-rules",
 				Rule:        "hardcoded-ip-address",
 				Incidents: []api.Incident{
-					{
-						File:     "/addon/source/tackle-testapp-public/target/classes/persistence.properties",
-						Line:     2,
-						Message:  "When migrating environments, hard-coded IP addresses may need to be modified or eliminated.",
-						CodeSnip: "jdbc.url=jdbc:oracle:thin:@10.19.2.93:15",
-					},
 					{
 						File:     "/addon/source/tackle-testapp-public/src/main/resources/persistence.properties",
 						Line:     2,
@@ -55,9 +49,9 @@ var TackleTestappPublicWithDeps = TC{
 				Rule:        "local-storage-00001",
 				Incidents: []api.Incident{
 					{
-						File:     "/cache/m2/io/konveyor/demo/configuration-utils/1.0.0/io/konveyor/demo/config/ApplicationConfiguration.java",
-						Line:     14,
-						Message:  "\n An application running inside a container could lose access to a file in local storage",
+						File:    "/cache/m2/io/konveyor/demo/configuration-utils/1.0.0/io/konveyor/demo/config/ApplicationConfiguration.java",
+						Line:    14,
+						Message: "\n An application running inside a container could lose access to a file in local storage",
 					},
 				},
 			},

diff --git a/analysis/tc_tackle_testapp_public_package_filter.go b/analysis/tc_tackle_testapp_public_package_filter.go
@@ -34,7 +34,7 @@ var TackleTestappPublicPackageFilter = TC{
 		},
 	},
 	Analysis: api.Analysis{
-		Effort: 2,
+		Effort: 1,
 		Issues: []api.Issue{
 			{
 				Category:    "mandatory",
@@ -43,12 +43,6 @@ var TackleTestappPublicPackageFilter = TC{
 				RuleSet:     "discovery-rules",
 				Rule:        "hardcoded-ip-address",
 				Incidents: []api.Incident{
-					{
-						File:     "/addon/source/tackle-testapp-public/target/classes/persistence.properties",
-						Line:     2,
-						Message:  "When migrating environments, hard-coded IP addresses may need to be modified or eliminated.",
-						CodeSnip: "jdbc.url=jdbc:oracle:thin:@10.19.2.93:15",
-					},
 					{
 						File:     "/addon/source/tackle-testapp-public/src/main/resources/persistence.properties",
 						Line:     2,