Skip to content

Commit

Permalink
🐛 removing testcase that finds the target, because we no longer create (
Browse files Browse the repository at this point in the history
#102)

* removing testcase that finds the target, because we no longer create it by default

Signed-off-by: Shawn Hurley <shawn@hurley.page>


---------

Signed-off-by: Shawn Hurley <shawn@hurley.page>
  • Loading branch information
shawn-hurley authored Mar 12, 2024
1 parent c5e0436 commit f1e5f21
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 24 deletions.
8 changes: 1 addition & 7 deletions analysis/tc_tackle_testapp_public.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ var TackleTestappPublic = TC{
},
Identities: []api.Identity{},
Analysis: api.Analysis{
Effort: 9,
Effort: 8,
Issues: []api.Issue{
{
Category: "mandatory",
Expand All @@ -35,12 +35,6 @@ var TackleTestappPublic = TC{
RuleSet: "discovery-rules",
Rule: "hardcoded-ip-address",
Incidents: []api.Incident{
{
File: "/addon/source/tackle-testapp-public/target/classes/persistence.properties",
Line: 2,
Message: "When migrating environments, hard-coded IP addresses may need to be modified or eliminated.",
CodeSnip: "jdbc.url=jdbc:oracle:thin:@10.19.2.93:15",
},
{
File: "/addon/source/tackle-testapp-public/src/main/resources/persistence.properties",
Line: 2,
Expand Down
14 changes: 4 additions & 10 deletions analysis/tc_tackle_testapp_public_deps.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ var TackleTestappPublicWithDeps = TC{

},
Analysis: api.Analysis{
Effort: 3,
Effort: 2,
Issues: []api.Issue{
{
Category: "mandatory",
Expand All @@ -33,12 +33,6 @@ var TackleTestappPublicWithDeps = TC{
RuleSet: "discovery-rules",
Rule: "hardcoded-ip-address",
Incidents: []api.Incident{
{
File: "/addon/source/tackle-testapp-public/target/classes/persistence.properties",
Line: 2,
Message: "When migrating environments, hard-coded IP addresses may need to be modified or eliminated.",
CodeSnip: "jdbc.url=jdbc:oracle:thin:@10.19.2.93:15",
},
{
File: "/addon/source/tackle-testapp-public/src/main/resources/persistence.properties",
Line: 2,
Expand All @@ -55,9 +49,9 @@ var TackleTestappPublicWithDeps = TC{
Rule: "local-storage-00001",
Incidents: []api.Incident{
{
File: "/cache/m2/io/konveyor/demo/configuration-utils/1.0.0/io/konveyor/demo/config/ApplicationConfiguration.java",
Line: 14,
Message: "\n An application running inside a container could lose access to a file in local storage",
File: "/cache/m2/io/konveyor/demo/configuration-utils/1.0.0/io/konveyor/demo/config/ApplicationConfiguration.java",
Line: 14,
Message: "\n An application running inside a container could lose access to a file in local storage",
},
},
},
Expand Down
8 changes: 1 addition & 7 deletions analysis/tc_tackle_testapp_public_package_filter.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ var TackleTestappPublicPackageFilter = TC{
},
},
Analysis: api.Analysis{
Effort: 2,
Effort: 1,
Issues: []api.Issue{
{
Category: "mandatory",
Expand All @@ -43,12 +43,6 @@ var TackleTestappPublicPackageFilter = TC{
RuleSet: "discovery-rules",
Rule: "hardcoded-ip-address",
Incidents: []api.Incident{
{
File: "/addon/source/tackle-testapp-public/target/classes/persistence.properties",
Line: 2,
Message: "When migrating environments, hard-coded IP addresses may need to be modified or eliminated.",
CodeSnip: "jdbc.url=jdbc:oracle:thin:@10.19.2.93:15",
},
{
File: "/addon/source/tackle-testapp-public/src/main/resources/persistence.properties",
Line: 2,
Expand Down

0 comments on commit f1e5f21

Please sign in to comment.