Bug 2038898: Adjust s3 initial values to match expected #1454
Conversation
openshift-ci
bot
added
approved
|
@ibolton336: This pull request references Bugzilla bug 2038898, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 2 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (prajoshi@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -55,9 +55,9 @@ const valuesHaveUpdate = (values: any, currentStorage: IStorage, isAWS: boolean) | |||
| } | |||
|
|
|||
| const existingS3URL = currentStorage.MigStorage.spec.backupStorageConfig.awsS3Url; | |||
| const existingRequireSSLValue = currentStorage.MigStorage.spec.backupStorageConfig.insecure; | |||
| const existingRequireSSLValue = !currentStorage.MigStorage.spec.backupStorageConfig.insecure; | |||
There was a problem hiding this comment.
The requireSSL value needs to be !insecure as it is here:
https://github.com/konveyor/mig-ui/blob/186cc4f97cc178096b18348b33282ac02a1a24e0/src/app/home/pages/StoragesPage/components/AddEditStorageModal/AddEditStorageForm.tsx#L53
when the initial value is set.
This is causing the isDisabled check to always show false since these 2 values are not matching up in the case of an s3 repo. None of the other repos allow manual setting of the "insecure" value, so that is why this bug only shows up for s3 repos.
Same story for the customCA value. If the value does not exist, hard set it to null instead of allowing it to be undefined for comparison purposes.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ibolton336, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ibolton336: All pull requests linked via external trackers have merged: Bugzilla bug 2038898 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.