make select dumb #37
make select dumb #37
Conversation
|
cc @koopjs/dev |
|
@chelm I couldn't find the use of idFilter in any of the existing Koop providers. Can you show me where/how its used? |
|
@dmfenton sure. It is super crucial and completely my fault for not docing it i guess. However, its also super concerning that it was removed, this would have been an issue pretty quickly I think. One sec. |
|
@dmfenton its used in the Exporter for dealing with large data. https://github.com/koopjs/koop/blob/master/lib/Exporter.js#L29-L44 This was introduced as an optimization in place of using |
|
also remember that typically providers will never call pgcache or any cache directly, they will always route through code in koop/lib in some way. So any breaking changes in the caches should be protected from the providers and handled more centrally. |
Good looking out. Really glad you were watching to catch that one. I'll add it back. We can consider a more general solution in the future. |
|
+1 for changelogs... |
|
And we're back |
| @@ -295,6 +281,7 @@ module.exports = { | |||
| * @returns {string} sql | |||
| */ | |||
| createWhereFromSql: function (where, fields) { | |||
| if (where === '1=1') return where | |||
|
doc looks good and tests are passing... lgtm. unless @chelm has ideas I say we push the green button. |
|
lgtm 👶 |
This PR removes all logic from the select function except getting feature collections from the database.
This is a breaking change.