Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: private model props #638

Merged
merged 2 commits into from
Jul 17, 2023
Merged

feat: private model props #638

merged 2 commits into from
Jul 17, 2023

Conversation

rgwozdz
Copy link
Member

@rgwozdz rgwozdz commented Jul 12, 2023

  • Add cacheSize options to Koop instance options; this will override the default LRU cache size (500)
  • Add cacheTtl options to provider registration options; if set, this is the default cache time for any data from a given provider
    • Make some model props private; these will still be available in the provider's class methods.

@rgwozdz rgwozdz self-assigned this Jul 12, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023

🦋 Changeset detected

Latest commit: ae0ea78

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@koopjs/koop-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rgwozdz rgwozdz requested a review from sansth1010 July 17, 2023 16:12
Copy link

@sansth1010 sansth1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rgwozdz rgwozdz merged commit 643b304 into master Jul 17, 2023
@rgwozdz rgwozdz deleted the private-model-props branch July 17, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants