-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI helper improvements #776
Commits on Jan 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9c1879b - Browse repository at this point
Copy the full SHA 9c1879bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c404828 - Browse repository at this point
Copy the full SHA c404828View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41c6725 - Browse repository at this point
Copy the full SHA 41c6725View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd4974c - Browse repository at this point
Copy the full SHA cd4974cView commit details -
cmake: better support cli-helper
* set C standard to C11 * create kart/kart_cli symlinks in dev, not just bundle * enable debug via `-DCMAKE_BUILD_TYPE=Debug`
Configuration menu - View commit details
-
Copy full SHA for 073cd99 - Browse repository at this point
Copy the full SHA 073cd99View commit details -
Enable via -DCMAKE_BUILD_TYPE=Debug at build-time and setting KART_HELPER_DEBUG=1 in the environment.
Configuration menu - View commit details
-
Copy full SHA for cefa071 - Browse repository at this point
Copy the full SHA cefa071View commit details -
helper: reorganise kart app finding.
Search for the kart executable via OS-specific methods if possible, falling back to argv[0]. Then look for sibling kart_cli. Then try again after re-resolving symlinks.
Configuration menu - View commit details
-
Copy full SHA for 1e941f8 - Browse repository at this point
Copy the full SHA 1e941f8View commit details -
helper: always enable unless KART_USE_HELPER=0
If Kart is built with -DCLI_HELPER=ON then make it on by default.
Configuration menu - View commit details
-
Copy full SHA for 934b87c - Browse repository at this point
Copy the full SHA 934b87cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2000d7c - Browse repository at this point
Copy the full SHA 2000d7cView commit details
Commits on Jan 22, 2023
-
e2e tests: improve helper mode
* enable test-run helper logging and dump log file after e2e tests * turn off/on explicitly to deal with helper mode being default enabled
Configuration menu - View commit details
-
Copy full SHA for 5e8ec12 - Browse repository at this point
Copy the full SHA 5e8ec12View commit details -
cli_helper: per-os tidyups; improved logging
* handle semget() flags correctly per-OS * add pid to log messages * make semnum a constant * build with -Wall & -Werror
Configuration menu - View commit details
-
Copy full SHA for f631526 - Browse repository at this point
Copy the full SHA f631526View commit details -
helper: improve logging; per-OS semaphore fixes
* write to helper log from helper & children, resolve to absolute path so that cwd changes don't break * more detailed logging around forks/pids, and exit/semaphore messaging * `union semun` is defined differently on Linux & macOS... even though they're effectively the same, reflect accurately On macOS/arm64, it's critical to define the final argument to semctl() as variadic via ctypes (ie: don't define it), because the calling convention differs between fixed and variadic arguments. python/cpython#92892
Configuration menu - View commit details
-
Copy full SHA for 369c6eb - Browse repository at this point
Copy the full SHA 369c6ebView commit details -
helper: reset sigchld handler in execution process
we set it to ignore in the helper itself, but if the execution kart process invokes a subprocess (eg: git) and interacts via asyncio, then the subprocess exit code is lost on Linux. Reset it to the default after the fork happens.
Configuration menu - View commit details
-
Copy full SHA for 8bbe034 - Browse repository at this point
Copy the full SHA 8bbe034View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8e8316 - Browse repository at this point
Copy the full SHA e8e8316View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e97ff5 - Browse repository at this point
Copy the full SHA 9e97ff5View commit details -
helper: disable by default, but enable in CI
Means local development builds don't have gotchas wrt code-reloading, but CI & release builds include it. Add a note to the contributing docs.
Configuration menu - View commit details
-
Copy full SHA for 11996e6 - Browse repository at this point
Copy the full SHA 11996e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57d106c - Browse repository at this point
Copy the full SHA 57d106cView commit details