Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified point-cloud-import --replace-existing to reuse tiles #783

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

olsen232
Copy link
Collaborator

@olsen232 olsen232 commented Feb 1, 2023

Modified point-cloud-import --replace-existing to reuse previously imported tiles, rather than reimport them, if tiles that have already been imported are imported again - potentially saving time and disk space.

This is particularly relevant when importing with convert-to-copc, since converting to COPC can make the hash differ each time and so cause the same points to be stored more than once in equivalent but not identical files, at different hashes.

Note that point-cloud-import --update-existing already had this optimization.

Checklist:

  • Have you reviewed your own change?
  • Have you included test(s)?
  • Have you updated the changelog?

Modified `point-cloud-import --replace-existing` to reuse previously
imported tiles, rather than reimport them, if tiles that have already been
imported are imported again - potentially saving time and disk space.

This is particularly relevant when importing with convert-to-copc, since
converting to COPC can make the hash differ each time and so cause the
same points to be stored more than once in equivalent but not identical
files, at different hashes.

Note that `point-cloud-import --update-existing` already had this
optimization.
@olsen232 olsen232 requested a review from craigds February 1, 2023 01:35
Copy link
Member

@rcoup rcoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@olsen232 olsen232 merged commit e96b4c0 into master Feb 1, 2023
@olsen232 olsen232 deleted the fix-replace-existing branch February 1, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants