Protect against XSS in diff-view by using application/json #884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #883
No extra tests yet, this is all the time I was willing to spend on it for right now.
Not clear if tests would be super valuable - we could test the following:
but honestly it seems like these would be pretty well tested already
We can't really test the following:
{"xss": "</script><script>alert(1)</script>"}
or some nonsense)Checklist: