Fixes a bug where minor XML changes are not suppressed properly #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Statistics-only changes to PAM files are considered minor and do not show up in diffs - this is because various tools generate them as a side effect without the user actually trying to modify the working copy. However, working-copy.is_dirty() checks are performed more efficiently than status or diff commands - they just search for a single dirty path and then do an early exit. The find-any-dirty-path logic did not (until now) properly suppress minor XML changes. This resulted in a bug whereby `kart status` and `kart diff` showed no changes, but attempting to switch branch would not work due to a the is_dirty() check returning True.
craigds
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statistics-only changes to PAM files are considered minor and do not show up in diffs - this is because various tools generate them as a side effect without the user actually trying to modify the working copy.
However, working-copy.is_dirty() checks are performed more efficiently than status or diff commands - they just search for a single dirty path and then do an early exit. The find-any-dirty-path logic did not (until now) properly suppress minor XML changes.
This resulted in a bug whereby
kart statusandkart diffshowed no changes, but attempting to switch branch would not work due to a the is_dirty() check returning True.Checklist: