Added delta-filters #998
Merged
Added delta-filters #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backwards compatible in that they do nothing unless you specify --delta-filter=<some-value> A bit like minimal-patches which we implemented a couple years back, but more powerful - more general-purpose - to avoid having to implement them again at some point. Basically, lets a consumer of JSON or JSON-LINES diff opt in or out of any of the following: - inserts - updates (old values) - updates (new values) - deletes But still see where the filtered out data is. Useful for generating changeset views of the data that don't need to show old values.
Note that you can't currently apply a delta-filter that is missing old revisions, this can be re-added later if needed. The replacement supports slightly different things to the original (if it was exactly the same there would be no point replacing it)
craigds
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backwards compatible in that they do nothing unless you specify --delta-filter=
A bit like minimal-patches which we implemented a couple years back, but more powerful - more general-purpose - to avoid having to implement them again at some point.
Basically, lets a consumer of JSON or JSON-LINES diff opt in or out of any of the following:
But still see where the filtered out data is.
Useful for generating changeset views of the data that don't need to show old values.
Checklist: