koorldet: remove logging field from the kubelet configz #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwzhang0107
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1907 +/- ##
==========================================
- Coverage 67.56% 67.56% -0.01%
==========================================
Files 413 413
Lines 46208 46229 +21
==========================================
+ Hits 31221 31235 +14
- Misses 12726 12727 +1
- Partials 2261 2267 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
saintube
reviewed
Feb 20, 2024
zwzhang0107
force-pushed
the
fix-kubelet-config
branch
3 times, most recently
from
128dbda
to
a157206
Compare
…ompatibility to 1.28 Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
zwzhang0107
force-pushed
the
fix-kubelet-config
branch
from
a157206
to
547eecc
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saintube
pushed a commit
to saintube/koordinator
that referenced
this pull request
Feb 22, 2024
…sh#1907) Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
saintube
pushed a commit
that referenced
this pull request
Feb 26, 2024
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
saintube
pushed a commit
to saintube/koordinator
that referenced
this pull request
Feb 26, 2024
…sh#1907) Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
saintube
pushed a commit
to saintube/koordinator
that referenced
this pull request
Feb 26, 2024
…sh#1907) Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
saintube
pushed a commit
that referenced
this pull request
Feb 26, 2024
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
ls-2018
pushed a commit
to ls-2018/koordinator
that referenced
this pull request
Mar 25, 2024
…sh#1907) Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
remove logging field from the kubelet configz for forward compatibility to 1.28
Ⅱ. Does this pull request fix one issue?
#1801
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test