Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: support CPU exclusive policy #359

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Jul 11, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

#227

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra added this to the v0.6 milestone Jul 11, 2022
@eahydra eahydra removed the request for review from FillZpp July 11, 2022 12:14
@eahydra eahydra self-assigned this Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #359 (048a3bd) into main (7d46fad) will increase coverage by 0.05%.
The diff coverage is 90.54%.

@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
+ Coverage   65.38%   65.43%   +0.05%     
==========================================
  Files         116      116              
  Lines       11467    11493      +26     
==========================================
+ Hits         7498     7521      +23     
- Misses       3383     3385       +2     
- Partials      586      587       +1     
Flag Coverage Δ
unittests 65.43% <90.54%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...scheduler/plugins/nodenumaresource/cpu_topology.go 30.35% <ø> (ø)
...heduler/plugins/nodenumaresource/node_numa_info.go 59.64% <57.14%> (-0.60%) ⬇️
...cheduler/plugins/nodenumaresource/cpu_allocator.go 83.63% <93.22%> (+0.68%) ⬆️
pkg/scheduler/plugins/nodenumaresource/plugin.go 69.72% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d46fad...048a3bd. Read the comment docs.

@hormes
Copy link
Member

hormes commented Jul 12, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit b78243b into koordinator-sh:main Jul 12, 2022
jasonliu747 pushed a commit to jasonliu747/koordinator that referenced this pull request Jul 26, 2022
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants