Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update GPU metrics in NodeMetric CRD #397

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

LambdaHJ
Copy link
Contributor

@LambdaHJ LambdaHJ commented Jul 22, 2022

Signed-off-by: 黄金 huangjin_henan@outlook.com

Ⅰ. Describe what this PR does

add gpu metrics to crd.

Ⅱ. Does this pull request fix one issue?

fixes #370

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #397 (5176c2f) into main (bf308ed) will increase coverage by 0.29%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   66.04%   66.34%   +0.29%     
==========================================
  Files         118      118              
  Lines       12004    12063      +59     
==========================================
+ Hits         7928     8003      +75     
+ Misses       3457     3436      -21     
- Partials      619      624       +5     
Flag Coverage Δ
unittests 66.34% <80.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/metriccache/storage_tables.go 57.14% <ø> (ø)
pkg/koordlet/metricsadvisor/collector.go 9.48% <ø> (+0.02%) ⬆️
pkg/koordlet/metricsadvisor/collector_gpu.go 36.31% <41.93%> (-1.43%) ⬇️
pkg/koordlet/metriccache/metric_cache.go 52.04% <100.00%> (+2.46%) ⬆️
pkg/koordlet/reporter/reporter.go 54.19% <100.00%> (+16.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf308ed...5176c2f. Read the comment docs.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, only few comments.

pkg/koordlet/metriccache/api.go Outdated Show resolved Hide resolved
pkg/koordlet/metriccache/storage_tables.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collector_gpu.go Outdated Show resolved Hide resolved
pkg/koordlet/reporter/reporter.go Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collector_gpu.go Outdated Show resolved Hide resolved
pkg/koordlet/metricsadvisor/collector_gpu.go Outdated Show resolved Hide resolved
pkg/koordlet/reporter/reporter.go Outdated Show resolved Hide resolved
@jasonliu747 jasonliu747 changed the title feat: add gpu metrics to crd feat: update GPU metrics in NodeMetric CRD Jul 22, 2022
Signed-off-by: 黄金 <huangjin_henan@outlook.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Jul 25, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 5b320c0 into koordinator-sh:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] koordlet updates device resource allocation status in NodeMetric
3 participants