-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update GPU metrics in NodeMetric CRD #397
Conversation
Codecov Report
@@ Coverage Diff @@
## main #397 +/- ##
==========================================
+ Coverage 66.04% 66.34% +0.29%
==========================================
Files 118 118
Lines 12004 12063 +59
==========================================
+ Hits 7928 8003 +75
+ Misses 3457 3436 -21
- Partials 619 624 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, only few comments.
0403419
to
e94a5f0
Compare
Signed-off-by: 黄金 <huangjin_henan@outlook.com>
e94a5f0
to
5176c2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, jasonliu747 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: 黄金 huangjin_henan@outlook.com
Ⅰ. Describe what this PR does
add gpu metrics to crd.
Ⅱ. Does this pull request fix one issue?
fixes #370
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test