Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: support kubelet cpu manager policy #434

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Aug 3, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the scheduler_support_kubelet_cpu_manager branch from 8f8e801 to 94fa65c Compare August 3, 2022 06:42
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Base: 67.96% // Head: 67.89% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (94fa65c) compared to base (9eb7b7d).
Patch coverage: 72.72% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   67.96%   67.89%   -0.08%     
==========================================
  Files         137      137              
  Lines       14976    14989      +13     
==========================================
- Hits        10179    10177       -2     
- Misses       4038     4051      +13     
- Partials      759      761       +2     
Flag Coverage Δ
unittests 67.89% <72.72%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...heduler/plugins/nodenumaresource/node_numa_info.go 56.80% <60.00%> (-0.62%) ⬇️
pkg/koordlet/runtimehooks/hooks/cpuset/rule.go 93.40% <100.00%> (ø)
...dlet/statesinformer/states_noderesourcetopology.go 67.40% <100.00%> (ø)
pkg/scheduler/plugins/nodenumaresource/plugin.go 71.47% <100.00%> (+0.17%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-9.48%) ⬇️

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hormes
Copy link
Member

hormes commented Aug 3, 2022

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 1e77f1f into koordinator-sh:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants