Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: LoadAware scheduling adds ScoreAccordingProdUsage parameter #883

Merged

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Dec 14, 2022

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

Add ScoreAccordingProdUsage in LoadAware scheduling plugin args to control whether to score according to the utilization of Prod Pod and keep the original default score according to node utilization

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…rameter

Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 66.48% // Head: 66.48% // No change to project coverage 👍

Coverage data is based on head (dc0e535) compared to base (c433d8f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #883   +/-   ##
=======================================
  Coverage   66.48%   66.48%           
=======================================
  Files         234      234           
  Lines       26639    26639           
=======================================
  Hits        17712    17712           
+ Misses       7686     7683    -3     
- Partials     1241     1244    +3     
Flag Coverage Δ
unittests 66.48% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scheduler/plugins/loadaware/load_aware.go 73.70% <100.00%> (ø)
pkg/koordlet/statesinformer/states_pods.go 54.60% <0.00%> (-2.13%) ⬇️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.26%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 67.05% <0.00%> (+1.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 7af9f66 into koordinator-sh:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants