Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: add more cli flags for audit log and ensure the audit log directory exist #912

Merged

Conversation

LeoLiuYan
Copy link
Contributor

Signed-off-by: LeoLiuYan 929908264@qq.com

Ⅰ. Describe what this PR does

  1. add more cli flags for audit log
  2. ensure the audit log directory exist

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: LeoLiuYan <929908264@qq.com>
@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Base: 66.63% // Head: 66.65% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (0b1f0b7) compared to base (52c3fa8).
Patch coverage: 35.29% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #912      +/-   ##
==========================================
+ Coverage   66.63%   66.65%   +0.01%     
==========================================
  Files         240      240              
  Lines       27769    27784      +15     
==========================================
+ Hits        18505    18520      +15     
- Misses       7992     7993       +1     
+ Partials     1272     1271       -1     
Flag Coverage Δ
unittests 66.65% <35.29%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/audit/event_logger.go 65.53% <26.66%> (-3.98%) ⬇️
pkg/koordlet/audit/config.go 100.00% <100.00%> (ø)
pkg/util/httputil/reverseproxy.go 84.84% <0.00%> (+0.53%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 67.05% <0.00%> (+5.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LeoLiuYan
Copy link
Contributor Author

@zwzhang0107 @jasonliu747 @saintube Please review the code when you having any idle time.

@zwzhang0107
Copy link
Contributor

/lgtm

@zwzhang0107
Copy link
Contributor

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 5d1cfe5 into koordinator-sh:main Jan 5, 2023
FillZpp pushed a commit that referenced this pull request Jan 16, 2023
…irectory exist (#912)

Signed-off-by: LeoLiuYan <929908264@qq.com>
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
…irectory exist (koordinator-sh#912)

Signed-off-by: LeoLiuYan <929908264@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants