-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: remove allocated in filter hook #918
koord-scheduler: remove allocated in filter hook #918
Conversation
fb23fb5
to
61c3793
Compare
dae355c
to
ea11418
Compare
Codecov ReportBase: 66.66% // Head: 66.60% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #918 +/- ##
==========================================
- Coverage 66.66% 66.60% -0.07%
==========================================
Files 240 243 +3
Lines 27769 28119 +350
==========================================
+ Hits 18513 18728 +215
- Misses 7987 8106 +119
- Partials 1269 1285 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@KunWuLuan thanks for your contribution. please add more unit tests for the cases. |
ea11418
to
a3204eb
Compare
a3204eb
to
ee68957
Compare
ee68957
to
ed346bd
Compare
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
ed346bd
to
a8e1d4b
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
Currently, the resource reservation plugin doesn't subtract allocated resources from the reservepod after allocating resources to the pod, which will lead to fewer available resources on the nodes.
For example, a reservation reserved 2c on node and the reservation allocated 1c to pod. In this case available resource on node is
allocated-2c
instead ofallocated-3c
.