-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: add new method GetPodIsAssigned to QuotaInfo #936
koord-scheduler: add new method GetPodIsAssigned to QuotaInfo #936
Conversation
Signed-off-by: kingeasternsun <kingeasternsun@gmail.com>
Codecov ReportBase: 66.45% // Head: 66.45% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #936 +/- ##
=======================================
Coverage 66.45% 66.45%
=======================================
Files 241 241
Lines 27901 27908 +7
=======================================
+ Hits 18541 18546 +5
+ Misses 8087 8085 -2
- Partials 1273 1277 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: kingeasternsun <kingeasternsun@gmail.com>
…nator-sh#936) Signed-off-by: kingeasternsun <kingeasternsun@gmail.com>
Signed-off-by: kingeasternsun kingeasternsun@gmail.com
Ⅰ. Describe what this PR does
when we get pods that is assigned from quota, we could just return them directly with lock once , instead of lock twice that with first lock we get all pods, with second lock we judge each pod and collect assigned pods.
Ⅱ. Does this pull request fix one issue?
no
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test