Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: add new method GetPodIsAssigned to QuotaInfo #936

Conversation

kingeasternsun
Copy link
Contributor

Signed-off-by: kingeasternsun kingeasternsun@gmail.com

Ⅰ. Describe what this PR does

when we get pods that is assigned from quota, we could just return them directly with lock once , instead of lock twice that with first lock we get all pods, with second lock we judge each pod and collect assigned pods.

Ⅱ. Does this pull request fix one issue?

no

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: kingeasternsun <kingeasternsun@gmail.com>
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 66.45% // Head: 66.45% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (0fc11ae) compared to base (26daa00).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #936   +/-   ##
=======================================
  Coverage   66.45%   66.45%           
=======================================
  Files         241      241           
  Lines       27901    27908    +7     
=======================================
+ Hits        18541    18546    +5     
+ Misses       8087     8085    -2     
- Partials     1273     1277    +4     
Flag Coverage Δ
unittests 66.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../scheduler/plugins/elasticquota/core/quota_info.go 83.14% <100.00%> (+0.67%) ⬆️
...duler/plugins/elasticquota/quota_overuse_revoke.go 70.05% <100.00%> (-0.53%) ⬇️
pkg/util/httputil/reverseproxy.go 84.30% <0.00%> (-0.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra changed the title ⚡ add new method GetPodIsAssigned to QuotaInfo koord-scheduler: add new method GetPodIsAssigned to QuotaInfo Jan 7, 2023
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 3b88616 into koordinator-sh:main Jan 7, 2023
FillZpp pushed a commit that referenced this pull request Jan 16, 2023
Signed-off-by: kingeasternsun <kingeasternsun@gmail.com>
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
…nator-sh#936)

Signed-off-by: kingeasternsun <kingeasternsun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants