koord-descheduler: limits frequently migrated workloads #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eahydra
requested review from
hormes,
FillZpp,
ZiMengSheng,
saintube,
jasonliu747 and
zwzhang0107
Codecov ReportBase: 66.99% // Head: 66.99% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #950 +/- ##
==========================================
- Coverage 66.99% 66.99% -0.01%
==========================================
Files 243 243
Lines 28166 28240 +74
==========================================
+ Hits 18871 18919 +48
- Misses 8008 8026 +18
- Partials 1287 1295 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
eahydra
changed the title
zwzhang0107
reviewed
Jan 12, 2023
hormes
reviewed
Jan 12, 2023
eahydra
force-pushed
the
descheduler_migration_support_frozen
branch
2 times, most recently
from
63ea6c6
to
db07d13
Compare
eahydra
changed the title
|
/lgtm |
eahydra
force-pushed
the
descheduler_migration_support_frozen
branch
from
db07d13
to
3aacd47
Compare
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
eahydra
force-pushed
the
descheduler_migration_support_frozen
branch
from
3aacd47
to
d7170ce
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FillZpp
pushed a commit
to FillZpp/koordinator
that referenced
this pull request
Jan 13, 2023
…sh#950) Signed-off-by: Joseph <joseph.t.lee@outlook.com> Signed-off-by: Siyu Wang <FillZpp.pub@gmail.com>
FillZpp
pushed a commit
that referenced
this pull request
Jan 16, 2023
Signed-off-by: Joseph <joseph.t.lee@outlook.com> Signed-off-by: Siyu Wang <FillZpp.pub@gmail.com>
lucming
pushed a commit
to lucming/koordinator
that referenced
this pull request
Feb 8, 2023
…sh#950) Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joseph joseph.t.lee@outlook.com
Ⅰ. Describe what this PR does
The migrationJob controller in koord-descheduler supports that limits frequently migrated workloads
objectLimitersto support control the limit duration and thresholds.maxMigratingin the duration , the workload will be limited. By default the duration is5 minutes,maxMigratingis nil that means will usemaxMigratingPerWorkloadinstead.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test