Fix policy editor script field #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the field name for the policy editor
scriptfield for before & after folder/snapshot actions.Instead of using the
scriptfield, thepathfield was being used. This caused issues where using a script body value would fail becuasepathexpects only an executable file, not the contents of a sh/cmd script. Using thescriptfield should properly allow an inline script to be used.See API server reference for
ActionCommand: https://github.com/kopia/kopia/blame/ba938cf58cc8db26eb373f6ddff5fc0e9c07af15/snapshot/policy/actions_policy.go#L23-L33