Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute as a Maven plugin #21

Closed
Tracked by #16
tisonkun opened this issue Jan 5, 2023 · 5 comments · Fixed by #84
Closed
Tracked by #16

Distribute as a Maven plugin #21

tisonkun opened this issue Jan 5, 2023 · 5 comments · Fixed by #84
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tisonkun
Copy link
Member

tisonkun commented Jan 5, 2023

So, this project is strongly inspired by license-maven-plugin, with an initial motivation to bring it beyond a Maven plugin.

But, with a core library to support basic check, format, and remove logic, we can evaluate building a maven plugin upon these core functions :)

The significant part is that we should populate properties correctly and do the right overriding. Also, the license-maven-plugin supports a few "multi" configs, while I'd prefer to use multiple executions simply. But this should also be verified.

@tisonkun tisonkun mentioned this issue Jan 5, 2023
20 tasks
@tisonkun tisonkun added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 5, 2023
@spencercjh
Copy link

spencercjh commented Aug 25, 2023

I will try to resolve this.

@tisonkun
Copy link
Member Author

tisonkun commented Aug 25, 2023

@spencercjh Glad to see you!

Most of the knowledge for packaging a Maven plugin, you can learn from the license-maven-plugin as linked above. Let me know if you need any help and it's encourage to submit a draft PR once you make any progress so we can talk on the same page.

@spencercjh
Copy link

spencercjh commented Aug 25, 2023

@spencercjh Glad to see you!

Most of the knowledge for packaging a Maven plugin, you can learn from the license-maven-plugin as linked above. Let me know if you need any help and it's encourage to submit a draft PR once you make any progress so we can talk on the same page.

Thanks for your reply.

It's my first to create a Maven plugin. And I create a simple Maven plugin sample #84 .

I want to know if this issue is aimed at migrating the work of hawkeye-command to hawkeye-maven-plugin.

And #64, isn't that the same?

@spencercjh
Copy link

I'm unsure how the style of Java is standardized for big organizations because Hawkeye is my first Java OSS to be involved. I found that Your import package order is not the same as mine. It's not relevant to the issue but directly related to my contribution.

@tisonkun
Copy link
Member Author

@spencercjh For this kind of style mismatch, you can fix by:

./mvnw spotless:apply

... and to apply license headers for all the new files (exactly what this repository want to do), you can refer to the README and fix it up. For example,

docker run --rm -v $(pwd):/github/workspace ghcr.io/korandoru/hawkeye-native:v3 format

... or test out your local version of HawkEye.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants