Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor configs from different sources #32

Closed
Tracked by #16
tisonkun opened this issue Jan 7, 2023 · 0 comments · Fixed by #40
Closed
Tracked by #16

Refactor configs from different sources #32

tisonkun opened this issue Jan 7, 2023 · 0 comments · Fixed by #40
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tisonkun
Copy link
Member

tisonkun commented Jan 7, 2023 •
edited
Loading

HawkEyeConfig can factor out ConfigFileModel and add new config keys like dryRun that are passed from the command line or other sources, which is unreasonable to be configured in the config file.
@tisonkun tisonkun mentioned this issue Jan 7, 2023
Closed
20 tasks
@tisonkun tisonkun changed the title HawkEyeConfig can factor out ConfigFileModel and add new config keys like dryRun that are passed from the command line or other sources, which is unreasonable to be configured in the config file. Refactor configs from different sources Jan 7, 2023
@tisonkun tisonkun added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 7, 2023
@tisonkun tisonkun mentioned this issue Jan 14, 2023
Merged
tisonkun added a commit that referenced this issue Jan 14, 2023
@tisonkun
feat: Support dryRun flag (#40)
d9e8f41 
This closes #32.

Signed-off-by: tison <wander4096@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support dryRun flag
1 participant
@tisonkun