Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that wrapper script is executable #45

Closed
aalmiray opened this issue Apr 26, 2021 · 1 comment
Closed

Verify that wrapper script is executable #45

aalmiray opened this issue Apr 26, 2021 · 1 comment
Assignees
@aalmiray
Labels
ant bach bug Something isn't working gradle jbang maven
Milestone
0.11.0

Comments

@aalmiray
Copy link
Contributor

Sometimes the wrapper script is not executable. Gum currently invokes the wrapper script anyway and nothing will happen as a result.

Gum should check if the file is executable or not. Output an error and fail immediately when that't the case as the presence of a wrapper indicates the project should use it.
@aalmiray aalmiray added bug Something isn't working gradle maven jbang labels Apr 26, 2021
@aalmiray aalmiray added this to the 0.11.0 milestone Apr 26, 2021
@aalmiray aalmiray self-assigned this Apr 26, 2021
@aalmiray
Copy link
Contributor Author

Thanks go to @tbee for helping spot this issue 😄

aalmiray added a commit that referenced this issue May 7, 2021
@aalmiray
Check that the chosen executable has executable bits turned ono. Fixes …
31f0596 
…#45
@aalmiray aalmiray closed this as completed May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aalmiray aalmiray

Labels
ant bach bug Something isn't working gradle jbang maven
Projects
None yet
Milestone
0.11.0
Development

No branches or pull requests
1 participant
@aalmiray