Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the latest version that works in Java 8 #60

Closed
renatoathaydes opened this issue Mar 27, 2020 · 4 comments
Closed

What is the latest version that works in Java 8 #60

renatoathaydes opened this issue Mar 27, 2020 · 4 comments

Comments

@renatoathaydes
Copy link

Hey, @aalmiray great work on this library! I would like to use this in LogFX but I want to keep supporting Java 8.

What would be the last version of this lib I can use with Java 8.

Cheers.

@aalmiray
Copy link
Collaborator

Hi @renatoathaydes, Ikonli 2.4.0 is the last version compatible with JDK8. I'm working on an option to bring back JDK8 compatibility for version 12.0.0 but it's not there yet.

@renatoathaydes
Copy link
Author

renatoathaydes commented Mar 27, 2020

That's fine @aalmiray it works perfectly now! This is such a valuable lib!! Thanks for making it.
I had been embedding FontAwesome in my jar by manually downloading it... With version 5, it was a nightmare to get it working in all OSs consistently - it would work in Linux, but not on Mac or Windows... then I fixed Mac, it wouldn't work on Linux... something really fishy going on... but anyway, I am now using your lib with the Themify pack and my app looks beautiful.

Just one detail: why are the CSS files and all fonts being included in the pack jar? I removed most of that from my fat jar and it still works fine (I keep only the woff file for Themify). Might be worth investigating if you could remove those (at least, I like to keep my jar slim - LogFX is still around 320KB which is quite good for all it does).

@renatoathaydes
Copy link
Author

Correction: I keep only the ttf file! Not the woff.

@aalmiray
Copy link
Collaborator

I’m including all those files because technically Ikonli redistributes work made by others and thus has to be compliant with licensing.

The good thing is that consumers can decide for themselves to repackage said resources, either using shade (Maven) or shadow (Gradle).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants