Fix volume not being set to zero #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The volume command is deprecated anyways, did I forget updating that? You should use applyFilters for that, could you update it there as well? |
|
I've marked the |
|
yes |
Update player to use filters on controlling volume
|
Updated WebsocketPlayer to use filters.volume on getter/setter of the volume, please check if I've done it right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library throws an error when setting the volume to zero, and found out that the negative part of the volume sanity check does not include zero. I'm not sure this is an intended part of the operation, but when I updated the code and set the volume to zero, it worked properly without any error.