Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Gradle 8.2 #840

Closed
wants to merge 1 commit into from
Closed

Upgrade to Gradle 8.2 #840

wants to merge 1 commit into from

Conversation

lukellmann
Copy link
Member

@lukellmann lukellmann commented Jun 30, 2023

The changes in gradle-wrapper.jar, gradle-wrapper.properties and gradlew are the result of running this command twice:

./gradlew wrapper --gradle-version 8.2 --gradle-distribution-sha256-sum 38f66cd6eef217b4c35855bb11ea4e9fbc53594ccccb5fb82dfd317ef8c2c5a3

This PR also includes:

@lukellmann
Copy link
Member Author

@DRSchlaubi do you have an idea how we can get rid of this warning?

> Task :common:jvmTest
The automatic loading of test framework implementation dependencies has been deprecated. This is scheduled to be removed in Gradle 9.0. Declare the desired test framework directly on the test suite or explicitly declare the test framework implementation dependencies on the test's runtime classpath. Consult the upgrading guide for further information: https://docs.gradle.org/8.2/userguide/upgrading_version_8.html#test_framework_implementation_dependencies

@DRSchlaubi
Copy link
Member

What is that even related to?

useJunitPlatform()?

@lukellmann
Copy link
Member Author

useJunitPlatform()?

it's already applied in the convention plugin

The changes in gradle-wrapper.jar, gradle-wrapper.properties and gradlew
are the result of running this command twice:
./gradlew wrapper --gradle-version 8.2 --gradle-distribution-sha256-sum
38f66cd6eef217b4c35855bb11ea4e9fbc53594ccccb5fb82dfd317ef8c2c5a3

This commit also includes:

 * removing no longer needed
   systemProp.org.gradle.unsafe.kotlin.assignment=true, see
   https://docs.gradle.org/8.2/release-notes.html#simple-property-assignment-in-kotlin-dsl-enabled-by-default

 * add org.gradle.kotlin.dsl.allWarningsAsErrors=true, see
   https://docs.gradle.org/8.2/release-notes.html#fail-on-script-compilation-warnings
@lukellmann
Copy link
Member Author

hm, it's just a warning, what about just ignoring it for now? (since i don't really understand it and don't know how to fix it)

@lukellmann lukellmann marked this pull request as ready for review July 7, 2023 21:27
@lukellmann
Copy link
Member Author

maybe gradle 8.2.1 fixes it?

@lukellmann
Copy link
Member Author

included these changes in #842

@lukellmann lukellmann closed this Jul 20, 2023
@lukellmann lukellmann deleted the gradle-8.2 branch July 20, 2023 19:47
@DRSchlaubi
Copy link
Member

maybe gradle 8.2.1 fixes it?

This isn't a Gradle issue, KGP just doesn't use the jvm-test-suite plugin, so kt has to fix it

@lukellmann
Copy link
Member Author

ok 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants