Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list-style-type: none #111

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Conversation

Frenzie
Copy link
Member

@Frenzie Frenzie commented Mar 6, 2018

@Frenzie
Copy link
Member Author

Frenzie commented Mar 6, 2018

@poire-z These failures are going to get annoying. But that's kind of the point. :-P Any comments on this PR? It seems like it couldn't be any simpler (and it works, obviously), but a second opinion before merging never hurts.

@poire-z
Copy link
Contributor

poire-z commented Mar 6, 2018

marker = L"\x0020"; is a space, with some width then ? No unwanted indentation with that ? Shouldn't it be just "" ?
(crengine is annoying enough by itself, it didn't need any help :)

@Frenzie
Copy link
Member Author

Frenzie commented Mar 6, 2018

No, it's good. Without that there's an unwanted lack of indentation.

With ""

screenshot_2018-03-06_22-08-11

With space

screenshot_2018-03-06_22-12-00

Browser (Firefox 58) for reference

(though it should come as no surprise that the list shows up with the same amount of space on the left)
screenshot_2018-03-06_22-12-38

@poire-z
Copy link
Contributor

poire-z commented Mar 6, 2018

I was rather thinking about when a very long sentence is wrapped, before another list item came into play.
But I guess all such wrapped lines are aligned, and that the marker is outside the paragraph, just like with squares. So I guess it should be fine.

@Frenzie
Copy link
Member Author

Frenzie commented Mar 6, 2018

If there is a problem it exists with each and every list style. Just check a couple of lines above and below. ;-)

@Frenzie Frenzie merged commit 052637f into koreader:master Mar 6, 2018
@Frenzie Frenzie deleted the list-style-none branch March 6, 2018 21:19
Frenzie added a commit to Frenzie/koreader-base that referenced this pull request Mar 6, 2018
Frenzie added a commit to koreader/koreader-base that referenced this pull request Mar 6, 2018
Frenzie added a commit to Frenzie/koreader that referenced this pull request Mar 6, 2018
Frenzie added a commit to koreader/koreader that referenced this pull request Mar 6, 2018
@poire-z
Copy link
Contributor

poire-z commented Jul 11, 2019

(Just a quick note, so I can later link to this observation)

When list-style-position: inside, list-style-type: none should take no space, as shown by Firefox:

image

I'll fix that in a later PR, as it should also be done with my rendering hacks of behaving like inside when outside and text-align right or center.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants