Table border and image zoom #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. support table borders , border-collapse(simple) and border-spacing. 2. support image's height and width properties, in px or %. Disabled zoomin of low resolution images. Now it only zoom out large images to fit the screen.
| } | ||
| } else { | ||
| if ( zoomIn ) { | ||
| if ( m_pbuffer->img_zoom_in_mode_block==0 ) | ||
| return; // no zoom | ||
| arbitraryImageScaling = m_pbuffer->img_zoom_in_mode_block == 2; | ||
| maxScale = m_pbuffer->img_zoom_in_scale_block; | ||
| //maxScale = m_pbuffer->img_zoom_in_scale_block; |
There was a problem hiding this comment.
@frankyifei , the change on this line causes segfault in readersearch's unit test. Do you know why? Looks like there is some kind of memory corruption in CVRendBlockCache. The segfault is coming from this function call: https://github.com/koreader/crengine/blob/master/crengine/src/lvtinydom.cpp#L5101
This was referenced Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zoom in of low resolution images. Now it only zoom out large images to
fit the screen.